[Chore] Upgrade Golang version to v1.25 by JiangJiaWei1103 · Pull Request #4269 · ray-project/kuberay

JiangJiaWei1103 · 2025-12-14T02:41:50Z

Why are these changes needed?

Go v1.25 has been released since Aug while KubeRay still uses v1.24.

Changes

Upgrade Go to v1.25 for Go module files, Dockerfiles, CI/CD configurations, pre-commit, and docs
Run go mod tidy to add missing modules and remove unused ones
Bump crd-ref-docs to v0.2.0 (please refer to the review comments below)
Bump golangci-cli to v2.7.2
- Got invalid version err, need to investigate

Note that Go v1.25 images use newer Debian base variants like Bookworm, so we choose golang:1.25.0-bookworm as the builder.

Related issue number

Closes #4263.

Checks

I've made sure the tests are passing.
Testing Strategy
- Unit tests
- Manual tests
- This PR is not tested :(

JiangJiaWei1103 · 2025-12-14T05:18:00Z

ray-operator/Makefile

 .PHONY: crd-ref-docs
 crd-ref-docs: $(CRD_REF_DOCS) ## Download crd-ref-docs locally if necessary.
-	test -s $(CRD_REF_DOCS) || GOBIN=$(LOCALBIN) go install github.com/elastic/crd-ref-docs@v0.0.12
+	test -s $(CRD_REF_DOCS) || GOBIN=$(LOCALBIN) go install github.com/elastic/crd-ref-docs@v0.2.0


We also bump crd-ref-docs to v0.2.0 to resolve build failures resulted from dependency on golang.org/x/tools v0.19.0.

Related PRs

Bump crd-ref-docs to v0.2.0 for Go 1.24+ compatibility #4029

Revert "Bump crd-ref-docs to v0.2.0 for Go 1.24+ compatibility" #4031

JiangJiaWei1103 · 2025-12-14T05:36:36Z

Hi @Future-Outlier,

For now, KubeRay depends on golangci-lint@v1.64.8, which is incompatible with Go v1.25. The change log of golangci-lint shows that v2.4.0 is the earliest version to support Go v1.25. As v2.7.2 is shown to be the latest stable version in golangcli-lint CI configuration. Would it make sense to just bump this tool to v2.7.2?

cc @rueian, @dentiny

Thanks!!

dentiny · 2025-12-14T09:41:38Z

Would it make sense to just bump this tool to v2.7.2?

make sense to me, I personally prefer to keep all dependencies and toolchain to the most latest stable version (maybe apart from rust toolchain)

win5923 · 2025-12-14T11:48:23Z

For now, KubeRay depends on golangci-lint@v1.64.8, which is incompatible with Go v1.25. The change log of golangci-lint shows that v2.4.0 is the earliest version to support Go v1.25. As v2.7.2 is shown to be the latest stable version in golangcli-lint CI configuration. Would it make sense to just bump this tool to v2.7.2?

There is already a PR addressing this: #4007, we can wait for this PR to be merged before proceeding with the Go version upgrade.
cc @seanlaii

JiangJiaWei1103 · 2025-12-14T11:53:12Z

Thanks @dentiny and @win5923 for the review. Let's wait for #4007 merged first.

seanlaii

Thanks!

ray-operator/go.mod

go.mod

Future-Outlier

cc @win5923 @machichima to review this

apiserver/Dockerfile

fscnick · 2025-12-17T13:33:26Z

experimental/Dockerfile

@@ -1,5 +1,5 @@
 # Build security proxy
-FROM golang:1.24.0-bullseye AS builder
+FROM golang:1.25.0-bookworm AS builder


The same as above

fscnick · 2025-12-17T13:36:49Z

ray-operator/Dockerfile

@@ -1,5 +1,5 @@
 # Build the manager binary
-FROM golang:1.24.0-bullseye AS builder
+FROM golang:1.25.0-bookworm AS builder


The same as above

ray-operator/DEVELOPMENT.md

ray-operator/go.mod

win5923

Hi @JiangJiaWei1103, could you help resolve the conflicts? The golang-lint-ci upgrade have already been merged.

Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com>

JiangJiaWei1103 · 2025-12-20T02:49:12Z

Hi @JiangJiaWei1103, could you help resolve the conflicts? The golang-lint-ci upgrade have already been merged.

Hi @win5923, I've rebase with the master branch, thanks!

Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com>

win5923

LGTM! I checked the CI error, and it is unrelated to this PR.

    rayservice_ha_test.go:168: [2025-12-20T07:45:53Z] Waiting several seconds before updating RayService
    rayservice_ha_test.go:171: [2025-12-20T07:46:23Z] Updating RayService
    support.go:188: [2025-12-20T07:46:23Z] Waiting for RayService test-ns-r9tpp/test-rayservice UpgradeInProgress condition to be true
    support.go:192: [2025-12-20T07:46:24Z] Waiting for RayService test-ns-r9tpp/test-rayservice to switch to a new cluster
    support.go:193: 
        Timed out after 60.000s.
        Expected
            <string>: test-rayservice-nrlmm
        not to equal
            <string>: test-rayservice-nrlmm

win5923 · 2025-12-22T08:46:48Z

Hi @JiangJiaWei1103, I think the conflicts may need to be resolved again. Thanks!

…upgrade-golang-ver Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com>

JiangJiaWei1103 · 2025-12-22T13:43:32Z

Hi @win5923,

The conflicts are resolved! Regarding go.work and go.work.sum, @Future-Outlier has opened another PR #4301 to remove them. Thanks!

(Update)
go.work issue is now resolved.

…upgrade-golang-ver Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com>

seanlaii

LGTM

Future-Outlier

LGTM, I tried to build historyserver's collector (it's not in CI now, and it works for me!)

cc @rueian to merge, thank you!

machichima

LGTM!

JiangJiaWei1103 commented Dec 14, 2025

View reviewed changes

seanlaii reviewed Dec 14, 2025

View reviewed changes

ray-operator/go.mod Show resolved Hide resolved

go.mod Show resolved Hide resolved

Future-Outlier reviewed Dec 15, 2025

View reviewed changes

fscnick reviewed Dec 17, 2025

View reviewed changes

win5923 reviewed Dec 17, 2025

View reviewed changes

ray-operator/go.mod Outdated Show resolved Hide resolved

win5923 reviewed Dec 20, 2025

View reviewed changes

JiangJiaWei1103 added 4 commits December 20, 2025 10:35

chore: Bump golang version to v1.25

1a43517

Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com>

chore: Bump crd-ref-docs to v0.2.0 for Go v1.25

d409092

Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com>

chore: Bump Go to v1.25.5

aeb6084

Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com>

fix: Remove patch ver for flexibility

3be6c3b

Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com>

JiangJiaWei1103 force-pushed the upgrade-golang-ver branch from 5c2fc63 to 3be6c3b Compare December 20, 2025 02:41

chore: Switch to floating tag for building images

47a32ce

Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com>

win5923 approved these changes Dec 21, 2025

View reviewed changes

Future-Outlier added this to @Future-Outlier's kuberay project Dec 22, 2025

Future-Outlier moved this to In Progress in @Future-Outlier's kuberay project Dec 22, 2025

JiangJiaWei1103 requested review from MortalHappiness, andrewsykim, kevin85421 and rueian as code owners December 22, 2025 12:55

JiangJiaWei1103 force-pushed the upgrade-golang-ver branch from d8dc92c to 47a32ce Compare December 22, 2025 13:23

Merge branch 'master' of https://github.com/ray-project/kuberay into …

db182d1

…upgrade-golang-ver Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com>

Merge branch 'master' of https://github.com/ray-project/kuberay into …

3a25fa3

…upgrade-golang-ver Signed-off-by: JiangJiaWei1103 <waynechuang97@gmail.com>

seanlaii approved these changes Dec 22, 2025

View reviewed changes

Future-Outlier approved these changes Dec 23, 2025

View reviewed changes

Future-Outlier moved this from In Progress to can be merged in @Future-Outlier's kuberay project Dec 24, 2025

JiangJiaWei1103 added this to My Kuberay & Ray Dec 24, 2025

JiangJiaWei1103 moved this to In review in My Kuberay & Ray Dec 24, 2025

machichima approved these changes Dec 25, 2025

View reviewed changes

rueian approved these changes Dec 26, 2025

View reviewed changes

rueian merged commit fe3aaf7 into ray-project:master Dec 26, 2025
27 checks passed

github-project-automation bot moved this from In review to Done in My Kuberay & Ray Dec 26, 2025

github-project-automation bot moved this from can be merged to Done in @Future-Outlier's kuberay project Dec 26, 2025

JiangJiaWei1103 deleted the upgrade-golang-ver branch December 26, 2025 12:32

Conversation

JiangJiaWei1103 commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why are these changes needed?

Changes

Related issue number

Checks

Uh oh!

JiangJiaWei1103 Dec 14, 2025

Choose a reason for hiding this comment

Related PRs

Uh oh!

JiangJiaWei1103 commented Dec 14, 2025

Uh oh!

dentiny commented Dec 14, 2025

Uh oh!

win5923 commented Dec 14, 2025

Uh oh!

JiangJiaWei1103 commented Dec 14, 2025

Uh oh!

seanlaii left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Future-Outlier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fscnick Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

fscnick Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

win5923 left a comment

Choose a reason for hiding this comment

Uh oh!

JiangJiaWei1103 commented Dec 20, 2025

Uh oh!

win5923 left a comment

Choose a reason for hiding this comment

Uh oh!

win5923 commented Dec 22, 2025

Uh oh!

JiangJiaWei1103 commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seanlaii left a comment

Choose a reason for hiding this comment

Uh oh!

Future-Outlier left a comment

Choose a reason for hiding this comment

Uh oh!

machichima left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

JiangJiaWei1103 commented Dec 14, 2025 •

edited

Loading

JiangJiaWei1103 commented Dec 22, 2025 •

edited

Loading